[Kde-hardware-devel] Re: Review Request: Use new KDE Power Management System's PolicyAgent for suppressing sleep and screen power management

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5729/
-----------------------------------------------------------

(Updated 2010-11-06 15:32:30.394173)


Review request for Solid and Kevin Ottens.


Changes
-------

Sorry it took so long - addressed all of Kevin's comments.


Summary
-------

With recent commits in kdebase/workspace/powerdevil, the KDE Power Management System has gained a new shiny PolicyAgent for handling inhibition requests, now with the killer feature of suppressing screen power management as well. This patch adds 2 more methods to Solid::PowerManagement and the DBus interface for the policy agent. If the patch will be accepted, the interface will be of course removed from powerdevil/, given that it is installed from within kdelibs.

Side effect - this patch also removes the usage of the fd.o interface from within Solid - even if the PolicyAgent is still compatible with it.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/solid/solid/CMakeLists.txt 1193618 
  /trunk/KDE/kdelibs/solid/solid/org.kde.Solid.PowerManagement.PolicyAgent.xml PRE-CREATION 
  /trunk/KDE/kdelibs/solid/solid/powermanagement.h 1193618 
  /trunk/KDE/kdelibs/solid/solid/powermanagement.cpp 1193618 
  /trunk/KDE/kdelibs/solid/solid/powermanagement_p.h 1193618 

Diff: http://svn.reviewboard.kde.org/r/5729/diff


Testing
-------


Thanks,

Dario

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101106/2635a2ed/attachment.htm