[Kde-hardware-devel] KDE/kdelibs/solid/tests

[Andreas Hartmetz]

On Thu, Feb 25, 2010 at 12:35 AM, David Faure <faure at kde.org> wrote:
> On Thursday 25 February 2010, Andreas Hartmetz wrote:
>> SVN commit 1095733 by ahartmetz:
>>
>> Fix the build (with tests).
>> I've been waiting for a situation to apply the #define private public hack
>> for years :)
>> CCMAIL: kde-hardware-devel at kde.org
>
> What about declaring the test class as friend, instead?
> That seems much cleaner.
>
It was *supposed* to be a throwaway hack ;)
I was unsure which part of Solid was wrong, so I "just made the test compile"
and waited for somebody else to fix it properly. I guess I should have made
that last part more explicit in the commit message.
I wasn't sure if the method was supposed to be private or not because a
commit message made it look like it was - OTOH, making a public
method private in a mature module does of course look wrong.