[Kde-hardware-devel] Hotplug dataengine performance

[Kevin Ottens]

On Friday 18 December 2009 12:04:57 Jacopo De Simoi wrote:
> -    HalDevice lock("/org/freedesktop/Hal/devices/computer");
> +    static HalDevice lock("/org/freedesktop/Hal/devices/computer");
> 
> now I'm down to ~50ms per device \o/
> Please let me know if there's a better way to implement the patch.

Indeed, going with the static local variable is not that great, but that keep 
things simple so I would go for it anyway. That said, I would change the type 
to Solid::Device instead of HalDevice, likely more robust and like we did with 
the "drive" local variable around the same place.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud patron of KDE, http://www.kdab.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20100221/a2142cc5/attachment.sig