[Kde-hardware-devel] Review Request: Fstab solid backend

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4984/#review7047
-----------------------------------------------------------


And of course there was some other styling mistake I didn't spot.

In particular (and this one I didn't point for each occurrence in the patch), in libsolid we use the "Type *t" convention, not the "Type* t" convention (obviously same remark for references). The patch is actually not even consistent regarding this particular one it uses a bit of both.


/trunk/KDE/kdelibs/solid/solid/backends/fstab/rootdevice.h
<http://reviewboard.kde.org/r/4984/#comment7115>

    Should be "const QString &" here for all three params.
    
    And the first one should be name "udi", not "uid".



/trunk/KDE/kdelibs/solid/solid/backends/fstab/rootdevice.h
<http://reviewboard.kde.org/r/4984/#comment7116>

    Please rename to m_udi.


- Kevin


On 2010-08-13 11:37:20, Mario Bensi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4984/
> -----------------------------------------------------------
> 
> (Updated 2010-08-13 11:37:20)
> 
> 
> Review request for Solid.
> 
> 
> Summary
> -------
> 
> Fstab solid backend. give informations and mechanism (to mount/unmount) on nfs and smb partition.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/solid/solid/CMakeLists.txt 1162929 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabdevice.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabdevice.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabhandling.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabhandling.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabmanager.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabmanager.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabservice.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabstorageaccess.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabstorageaccess.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/rootdevice.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/rootdevice.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/managerbase.cpp 1162929 
> 
> Diff: http://reviewboard.kde.org/r/4984/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20100814/4b813b3e/attachment.htm