[Kde-hardware-devel] Review Request: Fstab solid backend

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4984/#review7024
-----------------------------------------------------------


Good start already. Mostly about style issues in there.

Didn't have time (or necessary setup) to test it yet though. Likely next week.
Obviously missing feature though: reacting to changes in the fstab (to actually emit deviceAdded/deviceRemoved) or the mtab (to emit accessibilityChanged), but that can wait until we have a first committable version.

- Kevin


On 2010-08-11 12:44:30, Mario Bensi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4984/
> -----------------------------------------------------------
> 
> (Updated 2010-08-11 12:44:30)
> 
> 
> Review request for Solid.
> 
> 
> Summary
> -------
> 
> Fstab solid backend. give informations and mechanism (to mount/unmount) on nfs and smb partition.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/solid/solid/CMakeLists.txt 1162113 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabdevice.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabdevice.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabhandling.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabhandling.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabmanager.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabmanager.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabservice.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabstorageaccess.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabstorageaccess.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/rootdevice.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/rootdevice.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/managerbase.cpp 1162113 
> 
> Diff: http://reviewboard.kde.org/r/4984/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20100813/cf1f113f/attachment.htm