[Kde-hardware-devel] Solid device action predicates
Ozan Çağlayan
ozan at pardus.org.tr
Sat Jul 25 16:30:11 CEST 2009
Kevin Ottens wrote:
> Urgh! I'm not quite fan of the "e+1", it'll obviously break if the behavior
> changes and that we get -2 for instance, and moreover it's kind of a magic
> value in this context.
>
> Anyway I committed a proper fix just now[*] which checks the return value of
> keysToValue (aka the place where the error occurs) to reset the expected value
> to an invalid in this case.
>
> Note that I'm committing this with the accompanying unit tests. That generally
> makes it faster to debug something when you use those. ;-)
>
> Regards.
> [*] Revision 1001864 in trunk, backported as revision 1001868 in 4.3.
>
Thanks!
More information about the Kde-hardware-devel
mailing list