[Kde-hardware-devel] Patch to support Solid::Device::icon for ALSA and OSS devices with the HAL backend

Kevin Ottens ervin at kde.org
Thu Oct 16 14:35:39 CEST 2008


Le Monday 01 September 2008, Matthias Kretz a écrit :
> One thing I don't like about the patch is that reusing the code from
> Hal::AudioInterface needs the const_cast. Better ideas? Or ok to commit?

Well, the obvious alternative would be code duplication I think. So let's go 
with the const_cast. Could you please add a comment about it though? So that 
people working on this piece of code in the future are warned they could do 
something bad.

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20081016/fe1664a5/attachment.sig 


More information about the Kde-hardware-devel mailing list