Review Request 130215: Add a new button "Record screen" that allows to select a Screen Recording tool

[Nathaniel Graham]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130215/#review103819
-----------------------------------------------------------



Hi Gregor,
It looks great to me on first glance, but can you migrate this patch over to phabricator? Reviewboard is going to close down soon.

- Nathaniel Graham


On Oct. 16, 2017, 4:45 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130215/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2017, 4:45 p.m.)
> 
> 
> Review request for KDE Graphics, Boudhayan Gupta and Nathaniel Graham.
> 
> 
> Repository: spectacle
> 
> 
> Description
> -------
> 
> - Adds a new button "Record screen" that allows to select a Screen Recording tool, currently Peek and SimpleScreenRecorder.
> - Makes use of KMoreTools; so minimal code changes required.
> - Why? -> When the user presses "Print Screen" Spectacle opens. From there it is now easy to select a Screen recording tool.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 66d0d86494755740ae871e9b5ac184f4d870280d 
>   src/CMakeLists.txt ed9bb48cfd47bf97720b79ee64b67afc87dc0e06 
>   src/Gui/KSMainWindow.h fe5104c9f621651eeab5b8acac80a87f1db0111b 
>   src/Gui/KSMainWindow.cpp 5a4dd77564e98b961adcadcec18e5d5fad4d4bb4 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/130215/diff/1/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot of the new menu button
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/08/04/fe4db279-8d6b-45ec-8127-1e59b57e4fe6__screenshot_20170804_193832.png
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20171017/4a361854/attachment.html>