Review Request 130056: Selection text shows floating point rounding errors

[Lukas Hetzenecker]

> On March 29, 2017, 1:40 p.m., Boudhayan Gupta wrote:
> > Ship It!

I unfortunately don't have a Developer Account yet, could you submit it on my behalf? Thanks


- Lukas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130056/#review102970
-----------------------------------------------------------


On March 29, 2017, 7:50 a.m., Lukas Hetzenecker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130056/
> -----------------------------------------------------------
> 
> (Updated March 29, 2017, 7:50 a.m.)
> 
> 
> Review request for KDE Graphics and Boudhayan Gupta.
> 
> 
> Repository: spectacle
> 
> 
> Description
> -------
> 
> When a non-integer scale factor is used, the `selection.width * Screen.devicePixelRatio` calculation results in a floating-point multiplication and therefore needs to be rounded up before shown
> 
> 
> Diffs
> -----
> 
>   src/QuickEditor/EditorRoot.qml 8a5fc49 
> 
> Diff: https://git.reviewboard.kde.org/r/130056/diff/
> 
> 
> Testing
> -------
> 
> Selected area for screenshot on a 1.8 scale factor.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot_20170329_094106.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/03/29/5655660f-e8c9-4f07-b6a0-0509d9ba17a0__Screenshot_20170329_094106.png
> 
> 
> Thanks,
> 
> Lukas Hetzenecker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20170329/2dc15b10/attachment.html>