Review Request 129189: Fix blurry preview on HiDPI displays

Peter Wu peter at lekensteyn.nl
Thu Oct 20 20:47:48 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129189/
-----------------------------------------------------------

(Updated Oct. 20, 2016, 8:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Graphics and Boudhayan Gupta.


Changes
-------

Submitted with commit a41e83edbaadd27cd8ea85d4dfa375033e8ade84 by Peter Wu to branch master.


Repository: spectacle


Description
-------

THe captured pixmap should always have devicePixelRatio one, it only
needs to be changed when it is actually drawn in the preview widget.

Also fixes a regression from e4c2e564a5b91497132d9a20d8f521af405286bd
("Replace KScreen by QScreen for current window grab"), now the current
screen grab mode will again capture the full screen on HiDPI screens.

Tested with: QT_SCALE_FACTOR=2 src/spectacle


Diffs
-----

  src/Gui/KSImageWidget.cpp 365a5f327583a6d248b90eabdb0fb573b488589f 
  src/PlatformBackends/X11ImageGrabber.h 56381e8dc65b681bc8d67acebfb837d0900a7d90 
  src/PlatformBackends/X11ImageGrabber.cpp 6dc3ffd6dae0915dd2394d8a5bd468ceaa1baa0b 

Diff: https://git.reviewboard.kde.org/r/129189/diff/


Testing
-------

Image is sharper now with this option.


Thanks,

Peter Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20161020/e1d8b867/attachment.html>


More information about the Kde-graphics-devel mailing list