Review Request 129151: Don't use native color picker

[Antonio Rojas]

> On Oct. 11, 2016, 9:33 p.m., Aleix Pol Gonzalez wrote:
> > Isn't it an error in Qt then?
> > 
> > +1 anyway, because I tried and indeed it does nothing at the moment.
> 
> Antonio Rojas wrote:
>     I don't think so, kcolorchooser asks for a QColorDialog and Qt returns the native one as expected. Whatever happens next is not Qt's fault.
> 
> Aleix Pol Gonzalez wrote:
>     Note that all platform themes except for Plasma's are provided by Qt itself, so if it doesn't work on Gnome/XFCE it's because over there the QPT is doing something weird.

No, Qt is working as intended, by returning the GTK dialog. The problem is that kcolorchooser can't handle it (specifically: it can't add a help button to the QDialogButtonBox because there is no QDialogButtonBox at all, see lines 74 and next in kcolorchooser.cpp)


- Antonio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129151/#review99944
-----------------------------------------------------------


On Oct. 12, 2016, 8:04 a.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129151/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 8:04 a.m.)
> 
> 
> Review request for KDE Graphics and Christoph Feck.
> 
> 
> Repository: kcolorchooser
> 
> 
> Description
> -------
> 
> kcolorchooser fails to run in GTK desktops, since it tries to embed the native GTK color picker instead of the Qt one. This forces it to use the Qt dialog.
> 
> 
> Diffs
> -----
> 
>   kcolorchooser.cpp 9488b62 
> 
> Diff: https://git.reviewboard.kde.org/r/129151/diff/
> 
> 
> Testing
> -------
> 
> kcolorchooser runs in XFCE
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20161013/25ca71df/attachment-0001.html>