Review Request 129163: Capture all windows for "Window under cursor"

[Peter Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129163/
-----------------------------------------------------------

Review request for KDE Graphics and Boudhayan Gupta.


Bugs: 357223 and 369330
    https://bugs.kde.org/show_bug.cgi?id=357223
    https://bugs.kde.org/show_bug.cgi?id=369330


Repository: spectacle


Description
-------

Capture the correct area, not just the top-left one (bug 369330).
Capture all possible related windows, not just the top-level (or the
non-transient background window), this will correctly capture whole
applications including the open menus (bug 357223).

The last change also affects how windows with other overlapping ones are
captured, previously the hidden area is shown as if there was no popup.
For example, Kate would be captured and not its Open dialog.

Tested with Kate (Qt 5): Open File -> Add Places Entry -> Select Icon.
Verify that clicking all of these menus show the same screenshot and
that the non-overlapping parts are shown. Right-click to open a context
menu, this is also captured on the delayed screenshot.

Tested with heimdall-frontend and Hedgewars (Qt 4): open a menu, keep
the cursor on it. Verify that the menu and window are captured. Do the
same, but with the cursor outside the menu.

BUG: 369330
BUG: 357223


Diffs
-----

  src/PlatformBackends/X11ImageGrabber.h 513bf4bf14cd4c253635f716a6f5c103c48ea122 
  src/PlatformBackends/X11ImageGrabber.cpp 0525ec4259246cf7481071aaa35fff39bf6191a8 

Diff: https://git.reviewboard.kde.org/r/129163/diff/


Testing
-------

Testing as above. Other applications I tested with are:

- ImageMagick (`display x.png`) with the preview area and the popup menu, this was the most X-ey program I could remember. It is still captured correctly.
- Cursor on the Plasma desktop wallpaper now shows the windows on it, not just the wallpaper.
- Firefox with an Open File dialog with cursor on the file dialog which covers an area outside the window. The previous logic would use the area of the parent window resulting in cutting sides from the file dialog. Now it captures the dialog plus Firefox itself.


Thanks,

Peter Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20161012/8a4cdd8c/attachment.html>