Review Request 129127: Replace KScreen by QScreen for current window grab
Peter Wu
peter at lekensteyn.nl
Wed Oct 12 17:41:39 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129127/
-----------------------------------------------------------
(Updated Oct. 12, 2016, 5:41 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Graphics and Boudhayan Gupta.
Changes
-------
Submitted with commit e4c2e564a5b91497132d9a20d8f521af405286bd by Peter Wu to branch master.
Repository: spectacle
Description
-------
libkscreen is overkill for querying purposes, rely on QScreen to find
the current screen under cursor.
Diffs
-----
CMakeLists.txt a420b6cc3964cf4ffd4617e2eac45daf45c01fe7
src/CMakeLists.txt 71143c6b6d15a3cb8f732a4f45113000d0950249
src/PlatformBackends/X11ImageGrabber.h dd30eace2120f11f6dfd41b65abc09b7eeed33ab
src/PlatformBackends/X11ImageGrabber.cpp ecc3e3a38e4df4f739d948b437bc2262a6e2582e
Diff: https://git.reviewboard.kde.org/r/129127/diff/
Testing
-------
Tested in a dualhead setting having screens of the following geometries:
QScreen(0x15a1040, name="eDP-1") QRect(2560,360 1920x1080)
QScreen(0x15a0e50, name="DP-2") QRect(0,0 2560x1440)
Option "Current Screen" does indeed follow the mouse cursor.
Tested with `QT_SCALE_FACTOR=2`, the cursor position seems right.
Note: test was done with Qt 5.7.0, but the QScreen APIs are made for Qt5. Also note that better high DPI support requires Qt 5.6 (Qt 5.6 also fixed the multi-monitor issues that plagued earlier Qt versions).
Thanks,
Peter Wu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20161012/0210bd95/attachment.html>
More information about the Kde-graphics-devel
mailing list