Review Request 129151: Don't use native color picker
Christoph Feck
cfeck at kde.org
Wed Oct 12 13:50:23 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129151/#review99956
-----------------------------------------------------------
> kcolorchooser fails
Can you check other KDE applications that use QColorDialog, e.g. KolourPaint? I would hate to make applications force the native Qt dialog, just because some Qt integration fails.
- Christoph Feck
On Oct. 12, 2016, 10:04 a.m., Antonio Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129151/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2016, 10:04 a.m.)
>
>
> Review request for KDE Graphics and Christoph Feck.
>
>
> Repository: kcolorchooser
>
>
> Description
> -------
>
> kcolorchooser fails to run in GTK desktops, since it tries to embed the native GTK color picker instead of the Qt one. This forces it to use the Qt dialog.
>
>
> Diffs
> -----
>
> kcolorchooser.cpp 9488b62
>
> Diff: https://git.reviewboard.kde.org/r/129151/diff/
>
>
> Testing
> -------
>
> kcolorchooser runs in XFCE
>
>
> Thanks,
>
> Antonio Rojas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20161012/f2669e8b/attachment.html>
More information about the Kde-graphics-devel
mailing list