[Kde-graphics-devel] Review Request 127978: drop X-DBUS-StartupType key from kcolorchooser.desktop

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127978/#review95655
-----------------------------------------------------------


Ship it!




Looks good to me. KColorChooser can run multiple instances in parallel, but it's an application and not a "service" so we shouldn't use this DBUS key in the desktop entry.

- Michael Pyne


On May 20, 2016, 2:52 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127978/
> -----------------------------------------------------------
> 
> (Updated May 20, 2016, 2:52 p.m.)
> 
> 
> Review request for KDE Graphics.
> 
> 
> Repository: kcolorchooser
> 
> 
> Description
> -------
> 
> kcolorchooser doesn't seem to support it, and reports on quit:
> KDEInit could not launch
> as reported downstream at
> https://bugzilla.redhat.com/1337937
> https://bugs.mageia.org/show_bug.cgi?id=18307
> 
> I tried opening one @ bugs.kde.org, but found no kcolorchooser component
> 
> 
> Diffs
> -----
> 
>   kcolorchooser.desktop 83a6052 
> 
> Diff: https://git.reviewboard.kde.org/r/127978/diff/
> 
> 
> Testing
> -------
> 
> Runs fine after, no KDEInit errors on close
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20160520/29fbffd4/attachment.html>