[Kde-graphics-devel] Review Request 127814: Fix selected region on hidpi system

Boudhayan Gupta bgupta at kde.org
Tue May 3 04:49:06 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127814/#review95119
-----------------------------------------------------------


Ship it!




Makes sense. Shipt it.

Commit to Applications/16.04, then *cherry-pick* to master. This is important - master and Applications/16.04 have diverged, so don't merge.

- Boudhayan Gupta


On May 3, 2016, 12:16 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127814/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 12:16 a.m.)
> 
> 
> Review request for KDE Graphics, Boudhayan Gupta and Kai Uwe Broulik.
> 
> 
> Bugs: 357022
>     https://bugs.kde.org/show_bug.cgi?id=357022
> 
> 
> Repository: spectacle
> 
> 
> Description
> -------
> 
> The coordinate returned in a hidpi window is also scaled. Need to be scaled back to native one before clip the region.
> 
> 
> Diffs
> -----
> 
>   src/QuickEditor/EditorRoot.qml f7fb33b 
> 
> Diff: https://git.reviewboard.kde.org/r/127814/diff/
> 
> 
> Testing
> -------
> 
> Tested on a single screen setup, would appreciate if someone could test it on a multiscreen setup.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20160503/c5ebde52/attachment.html>


More information about the Kde-graphics-devel mailing list