[Kde-graphics-devel] Review Request 127317: Don't use range-based loops with Qt containers

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127317/
-----------------------------------------------------------

(Updated March 20, 2016, 10:34 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Graphics and Boudhayan Gupta.


Changes
-------

Submitted with commit d6d298e812cea42ca11df1581d09018b6e2939d9 by Daniel Vrátil to branch master.


Repository: spectacle


Description
-------

C++11 range-based loop syntax calls non-const iterators causing detach when used on Qt containers.


Diffs
-----

  CMakeLists.txt 897ba01 
  src/CMakeLists.txt e1eb3c1 
  src/Gui/ExportMenu.cpp 0232f4e 
  src/Gui/ScreenClipper.cpp 4e3555b 
  src/KipiInterface/KSGKipiImageCollectionSelector.cpp 8a5786c 
  src/PlatformBackends/X11ImageGrabber.h e6ad26f 
  src/PlatformBackends/X11ImageGrabber.cpp e07785a 

Diff: https://git.reviewboard.kde.org/r/127317/diff/


Testing
-------


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20160320/4e3dcb80/attachment.html>