[Kde-graphics-devel] Review Request 127317: Don't use range-based loops with Qt containers

[Boudhayan Gupta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127317/#review93359
-----------------------------------------------------------


Fix it, then Ship it!




Ship this!

I'm slowly converting all range-fors to Q_FOREACH in Spectacle anyway. There's too big a risk - if someone who isn't too experienced with C++11 submits a small patch to do something else and ends up detaching the whole container.


src/CMakeLists.txt 
<https://git.reviewboard.kde.org/r/127317/#comment63660>

    This patch should not contain the KScreen removal.


- Boudhayan Gupta


On March 9, 2016, 11 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127317/
> -----------------------------------------------------------
> 
> (Updated March 9, 2016, 11 p.m.)
> 
> 
> Review request for KDE Graphics and Boudhayan Gupta.
> 
> 
> Repository: spectacle
> 
> 
> Description
> -------
> 
> C++11 range-based loop syntax calls non-const iterators causing detach when used on Qt containers.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 897ba01 
>   src/CMakeLists.txt e1eb3c1 
>   src/Gui/ExportMenu.cpp 0232f4e 
>   src/Gui/ScreenClipper.cpp 4e3555b 
>   src/KipiInterface/KSGKipiImageCollectionSelector.cpp 8a5786c 
>   src/PlatformBackends/X11ImageGrabber.h e6ad26f 
>   src/PlatformBackends/X11ImageGrabber.cpp e07785a 
> 
> Diff: https://git.reviewboard.kde.org/r/127317/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20160309/443e109c/attachment.html>