[Kde-graphics-devel] Review Request 126820: KF5 port of KColorchooser
Hugo Parente Lima
hugo.pl at gmail.com
Mon Mar 7 18:45:22 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126820/
-----------------------------------------------------------
(Updated March 7, 2016, 6:45 p.m.)
Review request for KDE Graphics.
Changes
-------
Renamed icons to the new schema plus fixed the warning in CMakeLists.txt about the deprecated use of ECMInstallIcons.
Repository: kcolorchooser
Description
-------
KF5 port of KColorchooser
The port works like the KDE4 version, only missing thing: There's no down arrow rendered in the help button used to show the KHelpMenu.
A possible issue is that I'm using Qt classes to check if there's a color in the clipboard, in the real word is easier to have a string representing a color in the clipboard rather than an application/x-color, so I think this may be changed (probably in another patch).
Diffs (updated)
-----
CMakeLists.txt cb8a473c21492306fab36bc89021b98671e7bf99
hi16-app-kcolorchooser.png
hi22-app-kcolorchooser.png
kcolorchooser.cpp 35301195a1af144bd31547e8f91f06fd8f63d62b
Diff: https://git.reviewboard.kde.org/r/126820/diff/
Testing
-------
The application functionality is 98% a QColorDialog, 1% the KHelpMenu and 1% some command line argument handling, so I tested these last 2%.
Thanks,
Hugo Parente Lima
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20160307/c925f037/attachment.html>
More information about the Kde-graphics-devel
mailing list