[Kde-graphics-devel] Review Request 126820: KF5 port of KColorchooser

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126820/#review91825
-----------------------------------------------------------




CMakeLists.txt (line 24)
<https://git.reviewboard.kde.org/r/126820/#comment62687>

    This is missing?



CMakeLists.txt (line 33)
<https://git.reviewboard.kde.org/r/126820/#comment62688>

    This is also missing



kcolorchooser.cpp 
<https://git.reviewboard.kde.org/r/126820/#comment62689>

    You're missing KLocalizedString::setApplicationDomain and also you're going to need an aboutData.setTranslator(i18nc("NAME OF TRANSLATORS", "Your names"), i18nc("EMAIL OF TRANSLATORS", "Your emails"));
    
    See the reason at https://github.com/KDE/kalgebra/commit/b823636e5a39b9b8e693e1fb274d0f8e6005ffcb


- Albert Astals Cid


On Jan. 20, 2016, 3:40 a.m., Hugo Parente Lima wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126820/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 3:40 a.m.)
> 
> 
> Review request for KDE Graphics.
> 
> 
> Repository: kcolorchooser
> 
> 
> Description
> -------
> 
> KF5 port of KColorchooser
> 
> After years I'm back to KDE, wanted to help somehow the project and remembered I had a KDE developer account from a past era, this is my way to start to help with something.
> 
> The port works like the KDE4 version, only missing thing: There's no down arrow rendered in the help button used to show the KHelpMenu.
> 
> Other possible issue is that I'm using Qt classes to check if there's a color in the clipboard, in the real word is easier to have a string representing a color in the clipboard rather than an application/x-color, so I think this may be changed.
> 
> CMake file also need some love and I'm expecting comments there.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt cb8a473 
>   kcolorchooser.cpp 3530119 
> 
> Diff: https://git.reviewboard.kde.org/r/126820/diff/
> 
> 
> Testing
> -------
> 
> The application functionality is 98% a QColorDialog, 1% the KHelpMenu and 1% some command line argument handling, so I tested these last 2%.
> 
> 
> Thanks,
> 
> Hugo Parente Lima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20160131/468e90f5/attachment.html>