[Kde-graphics-devel] Review Request 126820: KF5 port of KColorchooser

[Hugo Parente Lima]

> On Feb. 16, 2016, 12:22 a.m., Albert Astals Cid wrote:
> > CMake Warning (dev) at /home/kdeunstable/instalado/share/ECM/modules/ECMInstallIcons.cmake:226 (message):
> >   ecm_install_icons() with no ICONS argument is deprecated
> > 
> > Can you fix that?

yes, but I just checked that I just call `ecm_install_icons(${ICON_INSTALL_DIR})`, and this `${ICON_INSTALL_DIR}` come from some Cmake/KDE build file, so seems the proper fix isn't in kcolorchooser cmake file.

Thanks.


- Hugo Parente


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126820/#review92420
-----------------------------------------------------------


On Feb. 11, 2016, 1:29 a.m., Hugo Parente Lima wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126820/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 1:29 a.m.)
> 
> 
> Review request for KDE Graphics.
> 
> 
> Repository: kcolorchooser
> 
> 
> Description
> -------
> 
> KF5 port of KColorchooser
> 
> The port works like the KDE4 version, only missing thing: There's no down arrow rendered in the help button used to show the KHelpMenu.
> 
> A possible issue is that I'm using Qt classes to check if there's a color in the clipboard, in the real word is easier to have a string representing a color in the clipboard rather than an application/x-color, so I think this may be changed (probably in another patch).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt cb8a473c21492306fab36bc89021b98671e7bf99 
>   hi16-app-kcolorchooser.png  
>   hi22-app-kcolorchooser.png  
>   kcolorchooser.cpp 35301195a1af144bd31547e8f91f06fd8f63d62b 
> 
> Diff: https://git.reviewboard.kde.org/r/126820/diff/
> 
> 
> Testing
> -------
> 
> The application functionality is 98% a QColorDialog, 1% the KHelpMenu and 1% some command line argument handling, so I tested these last 2%.
> 
> 
> Thanks,
> 
> Hugo Parente Lima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20160219/51ef4703/attachment.html>