[Kde-graphics-devel] Review Request 126485: Use SHARE_INSTALL_PREFIX to install renamed appstream data

Rex Dieter rdieter at gmail.com
Thu Feb 4 20:44:53 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126485/#review92065
-----------------------------------------------------------



fyi, I reverted the appdata name change, as the (appdata) specification requires that .desktop and appdata file basenames must match.

- Rex Dieter


On Dec. 23, 2015, 7:47 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126485/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2015, 7:47 p.m.)
> 
> 
> Review request for KDE Graphics and Martin Koller.
> 
> 
> Repository: kolourpaint
> 
> 
> Description
> -------
> 
> ...instead of hard-coding share/.. which is not helpful on a multiarch
> layout, where the prefix might be something like /usr/${arch} but arch
> independent files should still go into /usr/share.
> 
> Also renamed the appstream file to use reverse domain naming.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e6ef348 
>   kolourpaint.appdata.xml  
> 
> Diff: https://git.reviewboard.kde.org/r/126485/diff/
> 
> 
> Testing
> -------
> 
> kolourpaint.appdata.xml gets installed to the desired location.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20160204/43d97cb5/attachment.html>


More information about the Kde-graphics-devel mailing list