[Kde-graphics-devel] Review Request 126820: KF5 port of KColorchooser

[Hugo Parente Lima]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126820/
-----------------------------------------------------------

(Updated Feb. 1, 2016, 7:28 p.m.)


Review request for KDE Graphics.


Changes
-------

Fixed CMake commented lines and translators in the KAboutData.


Repository: kcolorchooser


Description
-------

KF5 port of KColorchooser

After years I'm back to KDE, wanted to help somehow the project and remembered I had a KDE developer account from a past era, this is my way to start to help with something.

The port works like the KDE4 version, only missing thing: There's no down arrow rendered in the help button used to show the KHelpMenu.

Other possible issue is that I'm using Qt classes to check if there's a color in the clipboard, in the real word is easier to have a string representing a color in the clipboard rather than an application/x-color, so I think this may be changed.

CMake file also need some love and I'm expecting comments there.


Diffs (updated)
-----

  CMakeLists.txt cb8a473c21492306fab36bc89021b98671e7bf99 
  hi16-app-kcolorchooser.png  
  hi22-app-kcolorchooser.png  
  kcolorchooser.cpp 35301195a1af144bd31547e8f91f06fd8f63d62b 

Diff: https://git.reviewboard.kde.org/r/126820/diff/


Testing
-------

The application functionality is 98% a QColorDialog, 1% the KHelpMenu and 1% some command line argument handling, so I tested these last 2%.


Thanks,

Hugo Parente Lima

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20160201/719d002e/attachment.html>