[Kde-graphics-devel] Review Request 125230: Initial RR for KF5/Qt5 port of kamera

[Marcus Meissner]

On Thu, Sep 17, 2015 at 05:15:15AM -0000, Christian Butcher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125230/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 5:15 a.m.)
> 
> 
> Review request for KDE Graphics, Christoph Feck and Jeremy Whiting.
> 
> 
> Repository: kamera
> 
> 
> Description
> -------
> 
> Initial RR for port of kamera to KF5/Qt5
> 
> Adds 'camera:/' protocol to kio
> 
> 
> Diffs (updated)
> -----
> 
>   CMakeLists.txt a201c0d9ea85e1c437fe991a1b1496622dffd930 
>   doc/CMakeLists.txt 6d5f6929d3d2f8276322456b78608a4f656414af 
>   doc/index.docbook 8bd7a76cf694c9e5bec7b6f4ea995c60a285848f 
>   kcontrol/CMakeLists.txt 9e6603f3e121bf56bccebecb6927831ffb77848e 
>   kcontrol/kamera.cpp 3e6540a5a49112bd00693486a0b815e551c6f6eb 
>   kcontrol/kamera.desktop cb5c7845ba4b57bf3bb3a23e548ef00efcff7a97 
>   kcontrol/kamera.h a91149dba6828687fc84a0e0892c3d6874b49362 
>   kcontrol/kameraconfigdialog.h 4f0ee67f37165b8dd424694032001cdc6cf18b57 
>   kcontrol/kameraconfigdialog.cpp b0d601f83dfd0649da533d3bd29ffd46914c6403 
>   kcontrol/kameradevice.h 828eda4df28a24d169f179abf6c43a8afa640fe7 
>   kcontrol/kameradevice.cpp 38f17871838a8847eef864d0a7ba429929ef46af 
>   kioslave/CMakeLists.txt ddf8f2cd6840b50b27157e6d57dc96244afbd613 
>   kioslave/kamera.h b072fca34252228392868750a2714ff3812d3aeb 
>   kioslave/kamera.cpp 081e96f681da708d91f59241ac9273be8f46e4b7 
>   solid_camera.desktop ce419407c372ca1b39c699fec7e583591712b4b1 
> 
> Diff: https://git.reviewboard.kde.org/r/125230/diff/

Not sure if one can comment in the interface, but well:



                if(widget_value_string && !strcmp(widget_value_string, widget_choice)) {
//					buttonGroup->setButton(i);
                    // TODO - setButton doesn't exist
                    // Work out what this was for and replace
                }

This code is for selecting the default choice in the menu/radio list. setButton(i) selected the i-th
entry.

There seems to be no functional changes to the libgphoto2 interaction code, so that is good.

I cannot speak about all the Qt5/KF5 parts, sorry.

I also have no good idea about CMake.

Ciao, Marcus