[Kde-graphics-devel] Review Request 125230: Initial RR for KF5/Qt5 port of kamera

[Luca Beltrame]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125230/#review85538
-----------------------------------------------------------



CMakeLists.txt (line 2)
<https://git.reviewboard.kde.org/r/125230/#comment59119>

    To have the version you want to add you could do this:
    
    ````
    # KDE Application Version, managed by release script
    set (KDE_APPLICATIONS_VERSION_MAJOR "15")
    set (KDE_APPLICATIONS_VERSION_MINOR "08")
    set (KDE_APPLICATIONS_VERSION_MICRO "1")
    set(KDE_APPLICATIONS_VERSION "${KDE_APPLICATIONS_VERSION_MAJOR}.${KDE_APPLICATIONS_VERSION_MINOR}.${KDE_APPLICATIONS_VERSION_MICRO}")
    set(PROJECT_VERSION ${KDE_APPLICATIONS_VERSION})
    
    ````
    And use KDE_APPLICATIONS_VERSION_MAJOR, MINOR and MICRO in the documentation. Doing things like this means the release scripts will auto-bump versions for you.



CMakeLists.txt (line 14)
<https://git.reviewboard.kde.org/r/125230/#comment59118>

    You may want to add the PURPOSE etc... commands to find_package so that it shows at the end, with the feature summary, what's required and what is missing.



CMakeLists.txt (line 20)
<https://git.reviewboard.kde.org/r/125230/#comment59117>

    Can you try doing like Jeremy suggested with regards to using Find* modules?



kcontrol/kamera.cpp (line 55)
<https://git.reviewboard.kde.org/r/125230/#comment59120>

    This means that everyone gets debug output, if I understand correctly. You may want to remove this before committing.



kioslave/kamera.cpp (line 92)
<https://git.reviewboard.kde.org/r/125230/#comment59121>

    Same as the other comment wrt debug.


- Luca Beltrame


On Set. 17, 2015, 7:15 a.m., Christian Butcher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125230/
> -----------------------------------------------------------
> 
> (Updated Set. 17, 2015, 7:15 a.m.)
> 
> 
> Review request for KDE Graphics, Christoph Feck and Jeremy Whiting.
> 
> 
> Repository: kamera
> 
> 
> Description
> -------
> 
> Initial RR for port of kamera to KF5/Qt5
> 
> Adds 'camera:/' protocol to kio
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a201c0d9ea85e1c437fe991a1b1496622dffd930 
>   doc/CMakeLists.txt 6d5f6929d3d2f8276322456b78608a4f656414af 
>   doc/index.docbook 8bd7a76cf694c9e5bec7b6f4ea995c60a285848f 
>   kcontrol/CMakeLists.txt 9e6603f3e121bf56bccebecb6927831ffb77848e 
>   kcontrol/kamera.cpp 3e6540a5a49112bd00693486a0b815e551c6f6eb 
>   kcontrol/kamera.desktop cb5c7845ba4b57bf3bb3a23e548ef00efcff7a97 
>   kcontrol/kamera.h a91149dba6828687fc84a0e0892c3d6874b49362 
>   kcontrol/kameraconfigdialog.h 4f0ee67f37165b8dd424694032001cdc6cf18b57 
>   kcontrol/kameraconfigdialog.cpp b0d601f83dfd0649da533d3bd29ffd46914c6403 
>   kcontrol/kameradevice.h 828eda4df28a24d169f179abf6c43a8afa640fe7 
>   kcontrol/kameradevice.cpp 38f17871838a8847eef864d0a7ba429929ef46af 
>   kioslave/CMakeLists.txt ddf8f2cd6840b50b27157e6d57dc96244afbd613 
>   kioslave/kamera.h b072fca34252228392868750a2714ff3812d3aeb 
>   kioslave/kamera.cpp 081e96f681da708d91f59241ac9273be8f46e4b7 
>   solid_camera.desktop ce419407c372ca1b39c699fec7e583591712b4b1 
> 
> Diff: https://git.reviewboard.kde.org/r/125230/diff/
> 
> 
> Testing
> -------
> 
> Can open camera using the 'camera:/' protocol in Dolphin.
> Can copy files from subdirectories of the camera to my $HOME directory.
> These files open properly.
> 
> Cannot open files in place on the camera, but suspect this due to a consolekit2 session management issue on my computer. ~/.xsession-errors describes the camera as busy for the 15 'tries' as handled by 'kioslace/kamera.cpp' in 'openKamera' function.
> 
> ~/.xsession-errors calls the destructor appropriately when disconnecting the camera.
> 
> 
> Thanks,
> 
> Christian Butcher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20150917/50a346c7/attachment-0001.html>