[Kde-graphics-devel] Review Request 124141: Take into account devicePixelRatio on "Select Region"

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124141/#review81619
-----------------------------------------------------------

Ship it!



regiongrabber.cpp (line 344)
<https://git.reviewboard.kde.org/r/124141/#comment55936>

    you can join these as:
    
    r.setSize(r.size() * pixelRatio)


- David Edmundson


On June 21, 2015, 3:02 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124141/
> -----------------------------------------------------------
> 
> (Updated June 21, 2015, 3:02 p.m.)
> 
> 
> Review request for KSnapshot.
> 
> 
> Repository: ksnapshot
> 
> 
> Description
> -------
> 
> If user is using QT_DEVICE_PIXEL_RATIO to any value different from 1 it has to be taken into account in painting operations (by setting it in QPixmap) and in layout calculations.
> 
> 
> Diffs
> -----
> 
>   regiongrabber.cpp 97af3fc 
> 
> Diff: https://git.reviewboard.kde.org/r/124141/diff/
> 
> 
> Testing
> -------
> 
> tested it with QT_DEVICE_PIXEL_RATIO at 2.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20150621/663295c0/attachment.html>