[Kde-graphics-devel] Review Request 122763: KIPI cleanups
Boudhayan Gupta
me at BaloneyGeek.com
Sat Feb 28 19:17:24 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122763/
-----------------------------------------------------------
Review request for KSnapshot.
Repository: ksnapshot
Description
-------
Cleans up some of the KIPI code.
Among other things, in ksnapshotsendtoactions.cpp I found code that was commented out, pragma message'd port to KF5, a line of code that went "plugin->actionCollection()->readShortcutSettings()", which upon further digging I found harked back from the KDE3.5 days, and that the API had been removed in KDElibs4. In fact, the shortcuts are already exposed inside the QAction items now, so this is gone.
Also split off the createSendToActions() into two - one for KService based actions and one for KIPI. Hopefully this'll help decouple KIPI even more. From the comments in the code I get the feeling everyone wants to decouple the KIPI bits as much as possible.
Diffs
-----
kipiinterface.h 8d866ef
kipiinterface.cpp 4d32647
ksnapshotimagecollectionshared.h 6cc6d9b
ksnapshotimagecollectionshared.cpp da097f0
ksnapshotsendtoactions.h f0b4f8f
ksnapshotsendtoactions.cpp a8c4ccb
Diff: https://git.reviewboard.kde.org/r/122763/diff/
Testing
-------
Builds, works, including KIPI plugins. Shortcuts are exposed.
Thanks,
Boudhayan Gupta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20150228/251c209e/attachment.html>
More information about the Kde-graphics-devel
mailing list