[Kde-graphics-devel] Review Request 122734: Fix build warnings - KRun::run deprecated for services, and unused variable.

[Boudhayan Gupta]

> On Feb. 27, 2015, 2:36 a.m., Aleix Pol Gonzalez wrote:
> > Thanks! Can you push the change?

I don't have commit access to the repos. In fact, I got a KDE identity just to put this patch on the Review Board. Can someone apply the patch for me?


- Boudhayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122734/#review76695
-----------------------------------------------------------


On Feb. 26, 2015, 8:01 p.m., Boudhayan Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122734/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 8:01 p.m.)
> 
> 
> Review request for KSnapshot.
> 
> 
> Repository: ksnapshot
> 
> 
> Description
> -------
> 
> In KF5, KRun::run is deprecated for services in favor of KRun::runService. This one-liner fixes that. Additionally, in the same line, the return value is saved to a bool variable which is checked with a Q_ASSERT macro; in Release builds this results in a warning about unused variables. This patch adds a Q_UNUSED macro after the Q_ASSERT macro to fix that.
> 
> 
> Diffs
> -----
> 
>   ksnapshot.cpp fe9c1e2 
> 
> Diff: https://git.reviewboard.kde.org/r/122734/diff/
> 
> 
> Testing
> -------
> 
> Build warnings are gone, no errors. Runs fine, takes screenshots fine. The 'Q' key shortcut to automatically take and save a screenshot also works.
> 
> My distribution (Arch) does not have KF5Kipi yet - all testing was done with Kipi disabled.
> 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20150227/c631a9f3/attachment.html>