[Kde-graphics-devel] Review Request 122553: Reenabled text to speech using QtSpeech as an optional dependency. Based on frameworks branch.
Jeremy Whiting
jpwhiting at kde.org
Fri Feb 13 18:09:03 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122553/
-----------------------------------------------------------
(Updated Feb. 13, 2015, 11:09 a.m.)
Review request for KDE Graphics, Albert Astals Cid and Frederik Gladhorn.
Changes
-------
Updated to fix errors when building without QtSpeech installed.
Repository: okular
Description
-------
If QtSpeech (dev branch) is built and installed this builds and works
very well.
Diffs (updated)
-----
ui/tts.cpp 6e39e20138ec3f946152f6246fedd5d8dc6482e3
ui/pageview.cpp f1886d3e556cbd2fe28c675b3c3317633d14d188
ui/tts.h cb990e97bf7980422cd41a64cfb783cd78bf1a6c
part.cpp 395b0e41386991d5a4e0eb340d088484c07f8a31
ui/pageview.h 4f423d72aad8a759d667ebe3011948ef9f9641bd
conf/okular.kcfg 55f5cdc6d497208fbe00eb2e0177b3c1e594d8b0
CMakeLists.txt b9bc1f4d557344a293907b3c02e4b0a5c1f01cb7
Diff: https://git.reviewboard.kde.org/r/122553/diff/
Testing
-------
It builds and runs well with qtspeech. I'll test building when qtspeech isn't installed tomorrow.
Thanks,
Jeremy Whiting
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20150213/f86cdb03/attachment.html>
More information about the Kde-graphics-devel
mailing list