[Kde-graphics-devel] Review Request 126485: Use SHARE_INSTALL_PREFIX to install appstream data

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126485/#review89982
-----------------------------------------------------------



CMakeLists.txt (line 394)
<https://git.reviewboard.kde.org/r/126485/#comment61674>

    the xml file should use reverse domain naming. It should be `org.kde.kolourpaint.appdata.xml`.


- Aleix Pol Gonzalez


On Dec. 23, 2015, 1:45 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126485/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2015, 1:45 p.m.)
> 
> 
> Review request for KDE Graphics and Martin Koller.
> 
> 
> Repository: kolourpaint
> 
> 
> Description
> -------
> 
> ...instead of hard-coding share/.. which is not helpful on a multiarch
> layout, where the prefix might be something like /usr/${arch} but arch
> independent files should still go into /usr/share.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e6ef348 
> 
> Diff: https://git.reviewboard.kde.org/r/126485/diff/
> 
> 
> Testing
> -------
> 
> kolourpaint.appdata.xml gets installed to the desired location.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20151223/dc0283de/attachment.html>