[Kde-graphics-devel] Review Request 126458: Make use of Purpose within Spectacle

[Boudhayan Gupta]

> On Dec. 22, 2015, 1:06 a.m., Boudhayan Gupta wrote:
> > src/Gui/KSMainWindow.cpp, line 154
> > <https://git.reviewboard.kde.org/r/126458/diff/1/?file=425106#file425106line154>
> >
> >     This is too much control logic in what's supposed to be purely a GUI class for my liking. Is it possible to put this outside somewhere, maybe in SpectacleCore or some other thin wrapper class around Purpose functionality?
> 
> Aleix Pol Gonzalez wrote:
>     How is it not GUI code to show a warning on the UI?

Disregard this one. I thought the whole block was the same function.


- Boudhayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126458/#review89847
-----------------------------------------------------------


On Dec. 22, 2015, 1:31 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126458/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 1:31 a.m.)
> 
> 
> Review request for KDE Graphics and Boudhayan Gupta.
> 
> 
> Repository: spectacle
> 
> 
> Description
> -------
> 
> Makes it possible to share using the Purpose framework.
> 
> Should probably remove Kipi, but I much rather have it in a separate patch.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 80f2df4 
>   src/CMakeLists.txt 15c378c 
>   src/ExportManager.h fd21f07 
>   src/ExportManager.cpp 0729a85 
>   src/Gui/KSMainWindow.h c7b2334 
>   src/Gui/KSMainWindow.cpp 3c75f1a 
> 
> Diff: https://git.reviewboard.kde.org/r/126458/diff/
> 
> 
> Testing
> -------
> 
> I shared a screenshot, and I liked it: http://i.imgur.com/SpW5Asu.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20151221/5e58526e/attachment.html>