[Kde-graphics-devel] Review Request 126458: Make use of Purpose within Spectacle

[Boudhayan Gupta]

> On Dec. 22, 2015, 1:06 a.m., Boudhayan Gupta wrote:
> >
> 
> Boudhayan Gupta wrote:
>     Overall, thanks a ton for taking the first steps. I'd suggest tackling the issues that I've opened below and pushing it to a new branch. Purpose just doesn't have as many plugins as KIPI now and that's something I want to change before mainlining this.

Oh, another thing I noticed - you're taking the screenshot picture from what was passed to the GUI widget. I want to eventually be able to export from the command line in background mode also, so that's not going to work. The image is held in ExportManager as a QPixmap (```pixmap()```). Note that ExportManager is a singleton so you can instantiate it anywhere you want. I think the idea of passing the image as a base64-encoded string is genius.


- Boudhayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126458/#review89847
-----------------------------------------------------------


On Dec. 22, 2015, 12:20 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126458/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 12:20 a.m.)
> 
> 
> Review request for KDE Graphics and Boudhayan Gupta.
> 
> 
> Repository: spectacle
> 
> 
> Description
> -------
> 
> Makes it possible to share using the Purpose framework.
> 
> Should probably remove Kipi, but I much rather have it in a separate patch.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 80f2df4 
>   src/CMakeLists.txt 15c378c 
>   src/Gui/KSMainWindow.h c7b2334 
>   src/Gui/KSMainWindow.cpp 3c75f1a 
>   src/PlatformBackends/ImageGrabber.h 5a1562c 
> 
> Diff: https://git.reviewboard.kde.org/r/126458/diff/
> 
> 
> Testing
> -------
> 
> I shared a screenshot, and I liked it: http://i.imgur.com/SpW5Asu.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20151221/54754fbf/attachment.html>