[Kde-graphics-devel] Review Request 126458: Make use of Purpose within Spectacle

[Boudhayan Gupta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126458/#review89847
-----------------------------------------------------------



src/Gui/KSMainWindow.cpp (line 154)
<https://git.reviewboard.kde.org/r/126458/#comment61583>

    This is too much control logic in what's supposed to be purely a GUI class for my liking. Is it possible to put this outside somewhere, maybe in SpectacleCore or some other thin wrapper class around Purpose functionality?



src/Gui/KSMainWindow.cpp (line 156)
<https://git.reviewboard.kde.org/r/126458/#comment61582>

    Don't use a QMessageBox. There's space for a KMessageWidget (it's currently used to notify users of a successfull copy-to-clipboard). Maybe you could re-use that KMessageWidget or its area.



src/Gui/KSMainWindow.cpp (line 232)
<https://git.reviewboard.kde.org/r/126458/#comment61584>

    This code should not exist at all here. This is a class only for the GUI. No control or utility logic should exist here. Maybe you could look at putting this in the wrapper class that I was talking about in the earlier issue.



src/PlatformBackends/ImageGrabber.h (line 69)
<https://git.reviewboard.kde.org/r/126458/#comment61585>

    Can you put this change in a separate commit and push it now?


- Boudhayan Gupta


On Dec. 22, 2015, 12:20 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126458/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 12:20 a.m.)
> 
> 
> Review request for KDE Graphics and Boudhayan Gupta.
> 
> 
> Repository: spectacle
> 
> 
> Description
> -------
> 
> Makes it possible to share using the Purpose framework.
> 
> Should probably remove Kipi, but I much rather have it in a separate patch.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 80f2df4 
>   src/CMakeLists.txt 15c378c 
>   src/Gui/KSMainWindow.h c7b2334 
>   src/Gui/KSMainWindow.cpp 3c75f1a 
>   src/PlatformBackends/ImageGrabber.h 5a1562c 
> 
> Diff: https://git.reviewboard.kde.org/r/126458/diff/
> 
> 
> Testing
> -------
> 
> I shared a screenshot, and I liked it: http://i.imgur.com/SpW5Asu.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20151221/4a22f8c0/attachment.html>