[Kde-graphics-devel] Review Request 123095: ksnapshot: load kipi-plugins

[Laurent Montel]

> On mars 31, 2015, 5:07 matin, Laurent Montel wrote:
> > Yes but your review doesn't fix bug no ?
> > You add more debug but it doesn't fix bug no ?
> > For me it's better that you create a review about a fix not just add debug and wait that it will fix no ?
> 
> Gregor Mi wrote:
>     Hi Laurent, sorry for the confusion. I think this a modus operandi issue: I used the reviewboard features to discuss _potential_ code changes and to find out how to proceed with the issue at hand. I am not sure yet if there is a bug in ksnapshot. So yes, the review does not fix anything (yet). The debug messages are meant to explain what I already found and to make discussions about the code easier.
>     
>     So, is it generally ok to use the reviewboard features in this way? (If yes, it probably should be made more clear in the description.)

Hi,
Reviewboad is used to provide a patch for fixing a bug, not for discussing about a potential bug.
When we spoke by default about a potential bug we use ML or direct emails.
For me this review will not used to fix a bug.
But now you started to use it for this potential bug you can continue :)
I hope that you will have more review :)

Regards


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123095/#review78263
-----------------------------------------------------------


On mars 30, 2015, 9:22 après-midi, Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123095/
> -----------------------------------------------------------
> 
> (Updated mars 30, 2015, 9:22 après-midi)
> 
> 
> Review request for KDE Frameworks, KDE Graphics, KSnapshot, and Gilles Caulier.
> 
> 
> Repository: ksnapshot
> 
> 
> Description
> -------
> 
> Currently the list of kipi-plugins loaded by ksnapshot is empty. This RR adds some comments to help with debugging.
> 
> The first question to be answered would be if the current ksnapshot code is supposed to work or if the issue of the empty list is to be solved somewhere else.
> 
> 
> Diffs
> -----
> 
>   ksnapshotsendtoactions.cpp a8c4ccbb72cee3bef486af417aa637c3f41de48d 
> 
> Diff: https://git.reviewboard.kde.org/r/123095/diff/
> 
> 
> Testing
> -------
> 
> Run ksnapshot, click the SendTo... button and see debug output:
> 
> m_pluginLoader->init()
> KIPI_FOUND...........
> m_pluginLoader->loadPlugins();
> ... pluginList.count() 0
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20150401/a6f9a48b/attachment.html>