[Kde-graphics-devel] Review Request 110349: KSnapshot: Do not open unexistent files

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110349/#review66524
-----------------------------------------------------------


thanks, but this is not quite the right fix. i've pushed a fix to the frameworks branch where current devel is happening. cheers, and thanks for taking the time to make a patch and submit it; it's what brought the issue to my attention (i just took over maintainership of the app so am catching up here still :)

- Aaron J. Seigo


On May 15, 2013, 2:20 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110349/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 2:20 p.m.)
> 
> 
> Review request for KDE Graphics, Aaron J. Seigo and Richard Moore.
> 
> 
> Bugs: 258431
>     http://bugs.kde.org/show_bug.cgi?id=258431
> 
> 
> Repository: ksnapshot
> 
> 
> Description
> -------
> 
> KSnapshot cannot open unsaved files because it uses the next incremented file number.
> Only increment the file name on a new screengrab.
> Now it is possible to edit temporary files that get removed after closing. This might confuse users but it still is better than not opening the file at all. (Maybe open temp file read only?)
> 
> I would like to commit this and cherry pick to 4.10.
> 
> Original patch by Jonathan Marten
> 
> 
> Diffs
> -----
> 
>   ksnapshot.cpp f5f3e40 
> 
> Diff: https://git.reviewboard.kde.org/r/110349/diff/
> 
> 
> Testing
> -------
> 
> 'Open with' works. Not only for the first file but for all snapshots. Saved and unsaved.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20140915/4c2c6a13/attachment.html>