[Kde-graphics-devel] Review Request 117745: Fix reporting libgphoto2 errors via KIO

[Lasse Liehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117745/
-----------------------------------------------------------

(Updated May 17, 2014, 7:03 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Graphics.


Repository: kamera


Description
-------

KIO::ERR_COULD_NOT_READ expects the error message parameter to be the file that could not be read. Instead an error message from libgphoto2 was given. Using KIO::ERR_SLAVE_DEFINED instead allows to report the libgphoto error as part of the error message.

Example from before: Could not read file Bad parameters.
Example from after: Could not read. Reason: Bad parameters


Diffs
-----

  kioslave/kamera.cpp f59c5a8 

Diff: https://git.reviewboard.kde.org/r/117745/diff/


Testing
-------

Checked that the error message is shown correctly in Dolphin.


Thanks,

Lasse Liehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20140517/780f8d61/attachment.html>