[Kde-graphics-devel] Review Request 117745: Fix reporting libgphoto2 errors via KIO

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117745/#review58103
-----------------------------------------------------------

Ship it!


I agree with the logic and the proposed fix, though I'll note I don't have any deep experience with KIO. The proof is in the testing though, so please commit.

- Michael Pyne


On April 24, 2014, 2:26 p.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117745/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 2:26 p.m.)
> 
> 
> Review request for KDE Graphics.
> 
> 
> Repository: kamera
> 
> 
> Description
> -------
> 
> KIO::ERR_COULD_NOT_READ expects the error message parameter to be the file that could not be read. Instead an error message from libgphoto2 was given. Using KIO::ERR_SLAVE_DEFINED instead allows to report the libgphoto error as part of the error message.
> 
> Example from before: Could not read file Bad parameters.
> Example from after: Could not read. Reason: Bad parameters
> 
> 
> Diffs
> -----
> 
>   kioslave/kamera.cpp f59c5a8 
> 
> Diff: https://git.reviewboard.kde.org/r/117745/diff/
> 
> 
> Testing
> -------
> 
> Checked that the error message is shown correctly in Dolphin.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20140517/69d44a06/attachment.html>