[Kde-graphics-devel] Review Request 118036: Make sure we are sending a valid WId to kwalletd

[Teo Mrnjavac]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118036/
-----------------------------------------------------------

Review request for KDE Graphics.


Repository: libksane


Description
-------

Invoking winId() inside the widget's code will pass only that widget's WId, not the WId of an actual window the widget belongs to, and this can crash kwalletd if the widget is not top-level.
Replaced winId() with effectiveWinId().


Diffs
-----

  src/ksane.cpp f304363 

Diff: https://git.reviewboard.kde.org/r/118036/diff/


Testing
-------


Thanks,

Teo Mrnjavac

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20140507/8cce62c8/attachment.html>