[Kde-graphics-devel] Review Request 115350: Set window property to not animate KSnapshot's window on close

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115350/#review48459
-----------------------------------------------------------



ksnapshot.cpp
<https://git.reviewboard.kde.org/r/115350/#comment34264>

    "long" can be either 32 bit or 64 bit, depending on compiler/platform.
    
    I know nothing of X11 API, so I trust you that this is indeed the correct datatype here.


- Christoph Feck


On Jan. 28, 2014, 8:21 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115350/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 8:21 a.m.)
> 
> 
> Review request for KDE Graphics and Richard Moore.
> 
> 
> Bugs: 279615
>     http://bugs.kde.org/show_bug.cgi?id=279615
> 
> 
> Repository: ksnapshot
> 
> 
> Description
> -------
> 
> Starting with KWin 4.11.6 [1] there is a hint to exclude a window from
> the closing animation. KSnapshot can use this to ensure that it doesn't
> capture itself. With other compositors (e.g. Compiz) KSnapshot is most
> likely still capturing itself. There is nothing KSnapshot can do about
> it. Of course affected users are invited to point the developers of
> other compositors to this commit and suggest to implement the KWin
> specific hint.
>     
> BUG: 279615
> FIXED-IN: 4.12.2
>     
> [1] http://commits.kde.org/kde-workspace/41c77675e6bb0bbb4b50c121f8c81799fa2e411b
> 
> 
> Diffs
> -----
> 
>   ksnapshot.cpp ca308bb 
> 
> Diff: https://git.reviewboard.kde.org/r/115350/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20140128/90045fc0/attachment.html>