[Kde-graphics-devel] Review Request 120920: Fill SendTo menu async to fix "Bug 312495 - Very slow 'Send to' menu"
Gregor Mi
codestruct at posteo.org
Wed Dec 3 23:53:37 UTC 2014
> On Dec. 3, 2014, 7:34 p.m., Kevin Funk wrote:
> > Well, and please also test with KIPI_FOUND set -- Why is that not set for you?
> >
> > Requires:
> > libkipi-dev - KDE Image Plugin Interface library -- development files
I am currently on the frameworks branch. As said, I wonder why KIPI_FOUND is not set although I see the following cmake output:
...
-- The following OPTIONAL packages have been found:
KF5Kipi
X11
XCB , X protocol C-language Binding , http://xcb.freedesktop.org
PkgConfig
X11_XCB , Xlib/XCB interface library , http://xcb.freedesktop.org
...
build/config-ksnapshot.h contains /* #undef KIPI_FOUND */
I did ./kdesrc-build libkipi and libkipi-dev is installed. I use KDE 4.14.3 as underlying desktop.
I currently do not fully understand the mechanism between the given cmake output and the content of the generated config-ksnapshot.h. I think they should be somehow related.
- Gregor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120920/#review71302
-----------------------------------------------------------
On Nov. 21, 2014, 8:55 p.m., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120920/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 8:55 p.m.)
>
>
> Review request for KDE Graphics, KSnapshot, Aaron J. Seigo, and Dominik Haumann.
>
>
> Bugs: 312495
> http://bugs.kde.org/show_bug.cgi?id=312495
>
>
> Repository: ksnapshot
>
>
> Description
> -------
>
> Hi, I also feel slightly impaired by Bug 312495 - Very slow "Send to" menu. So here is a fix.
>
> It consists of the following commits:
> 1. move long-running retrieval of SendTo items to separate method
> 2. fillSendToActionsCache at startup but not yet async
> 3. move code related to SendTo actions to own class and file
> (this includes the kipi code but KIPI_FOUND was not set in my dev env so thats not tested)
> 4. SendTo menu is built on a separate thread to speed up populating
> 5. delete actions in dtor
>
> The SendTo actions are now created in QThread which is started on startup of ksnapshot.
> If the user opens the SendTo menu too soon there is a message (as single menu item) that says
> that the menu is still being constructed and that he/she should try a moment later.
>
>
> Diffs
> -----
>
> main.cpp e7a1efb2fd8398492b96e6f21f90363d99358e12
> ksnapshotsendtoactions.h PRE-CREATION
> ksnapshotsendtoactions.cpp PRE-CREATION
> ksnapshot.h 4e062de8afe5cfd9a98b769f105b1a174b58dc9f
> ksnapshot.cpp 6bd38e1508f4887c17a43e2c5cedaf19e1a1dab2
> CMakeLists.txt 627e3b4467578205125125323fb682126dd291e6
> .reviewboardrc PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/120920/diff/
>
>
> Testing
> -------
>
> 1)
> - Start ksnapshot (notice that is as fast as before)
> - Immediately open SendTo menu => there is a message that the menu is not ready yet.
> - Try again after 1 second: menu is populated.
> - Close ksnapshot.
>
> 2)
> - Start ksnapshot. Wait two seconds and then click SendTo menu
> => menu is populated right away
> - Close it.
>
> 3)
> Start ksnapshot. Hit the SendTo menu with insanely high button click speed.
> => No crash observed.
>
> 4)
> Start ksnapshot and close it immediately.
> => No crash observed.
>
> 5) [pending]
> Could no test the kipi code because KIPI_FOUND is not set yet on my environment.
>
>
> Thanks,
>
> Gregor Mi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20141203/83d1c84b/attachment-0001.html>
More information about the Kde-graphics-devel
mailing list