[Kde-graphics-devel] Review Request 113401: Expose the mobipocket library as qmobipocket

[Vishesh Handa]

> On Oct. 28, 2013, 11:04 a.m., Albert Astals Cid wrote:
> > Maybe I wasn't clear in my previous comment. I don't think it makes sense for the export file to have a LGPL license when the rest of the code is GPL. What is your opinion?
> 
> Vishesh Handa wrote:
>     ohhh! Then I think it would make sense to have the export file GPL licensed.
> 
> Albert Astals Cid wrote:
>     Can you then update the review request with that?

Sorry. I've been hacking on other stuff :/


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113401/#review42517
-----------------------------------------------------------


On Oct. 28, 2013, 10:25 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113401/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2013, 10:25 a.m.)
> 
> 
> Review request for KDE Graphics and Albert Astals Cid.
> 
> 
> Repository: kdegraphics-mobipocket
> 
> 
> Description
> -------
> 
>     Export the lib as qmobipocket
>     
>     The Nepomuk mobi pocket analyzer needs this library for indexing mobi
>     file metadata.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 44fa47a 
>   QMobipocketConfig.cmake PRE-CREATION 
>   lib/CMakeLists.txt PRE-CREATION 
>   lib/mobipocket.h fa716af 
>   lib/qmobipocket_export.h PRE-CREATION 
>   okular/CMakeLists.txt 9b63875 
>   strigi/CMakeLists.txt d5c3cab 
>   thumbnailers/CMakeLists.txt 39b6b91 
> 
> Diff: http://git.reviewboard.kde.org/r/113401/diff/
> 
> 
> Testing
> -------
> 
> Tested by porting the nepomuk mobipocket indexer to use this library.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20131029/ef7926ee/attachment.html>