[Kde-graphics-devel] Review Request 113401: Expose the mobipocket library as qmobipocket

[Vishesh Handa]

> On Oct. 23, 2013, 6 p.m., Albert Astals Cid wrote:
> > I'd move the 
> > virtual ~Stream() {}
> > to the .cpp in case we want to implement it somewhen
> > 
> > Also what do you think about exporting the QFileStream? not needed for now?

The implementation of QFileStream is very trivial. I'd like to avoid exporting as many things as possible. What do you think?


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113401/#review42245
-----------------------------------------------------------


On Oct. 23, 2013, 12:51 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113401/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 12:51 p.m.)
> 
> 
> Review request for KDE Graphics and Albert Astals Cid.
> 
> 
> Repository: kdegraphics-mobipocket
> 
> 
> Description
> -------
> 
>     Export the lib as qmobipocket
>     
>     The Nepomuk mobi pocket analyzer needs this library for indexing mobi
>     file metadata.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 44fa47a 
>   QMobipocketConfig.cmake PRE-CREATION 
>   lib/CMakeLists.txt PRE-CREATION 
>   lib/mobipocket.h fa716af 
>   lib/qmobipocket_export.h PRE-CREATION 
>   okular/CMakeLists.txt 9b63875 
>   strigi/CMakeLists.txt d5c3cab 
>   thumbnailers/CMakeLists.txt 39b6b91 
> 
> Diff: http://git.reviewboard.kde.org/r/113401/diff/
> 
> 
> Testing
> -------
> 
> Tested by porting the nepomuk mobipocket indexer to use this library.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20131023/a2d4d84a/attachment.html>