[Kde-graphics-devel] Review Request: Fixed Bug 136142: KSnapshot can now take screenshots of windows no matter how narrow they are.

[Adrián Chaves Fernández]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107555/
-----------------------------------------------------------

Review request for KDE Graphics.


Description
-------

KSnapshot, when used with window regions, was ignoring the first child window (index 0). This was not a problem with usual window sizes, because the first region in the array was usually not the one targeted (probably it was one of the close/maximize/minimize buttons on the window). However, when reduzing the size of the window so that those buttons dissapeared, the main region of a window would be the first item on the array of regions (index 0), and would be ignored.

Anyway, it was just a faulty if.


This addresses bug 136142.
    http://bugs.kde.org/show_bug.cgi?id=136142


Diffs
-----

  windowgrabber.cpp 5de0f8b 

Diff: http://git.reviewboard.kde.org/r/107555/diff/


Testing
-------

I‘ve manually followed the steps in the bug report:

1. Open a window that can be resized to be very narrow - e.g., xclock
2. Decrease its width to about 80px - until the close button disappears
3. Run ksnapshot, select the "Section of window" mode, and take a screenshot.


Thanks,

Adrián Chaves Fernández

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20121202/85056201/attachment.html>