[Kde-graphics-devel] [PATCH] ksnapshot: add feedback about when snapshot will be taken.

[Lubos Lunak]

On Friday 08 of February 2008, Thomas Coopman wrote:
> Hi,
>
> This patch shows the user when the snapshot will be taken.
>
> I don't know if this was the best way of doing this, so feedback is
> appreciated.
>
> snapshot of the feedback:
> http://picasaweb.google.co.uk/thomas.coopman/BlogPictures/photo#51645242659
>27462770

 The patch, if I'm getting it right, simply always puts the message at (0,0). 
To make it Xinerama aware, it should be put at 
KGlobalSettings::desktopGeometry( ksnapshotgeometry.center()).topLeft().

 Also, some people may have useful things in the topleft corner and the 
message should not be getting in the way - it should have the input shape set 
to none. There's no Qt function for that, it needs using Xlib directly, and 
it's also available only since the 1.1 XShape version. 

 For the version check, see e.g. kdebase/workspace/kwin/lib/kwinglobals.cpp 
(Extensions::shapeInputAvailable(), Extensions::init()), setting the shape 
should be just XShapeCombineRectangles( QX11Info::display(), winId(), 
ShapeInput, 0, 0, NULL, 0, ShapeSet, Unsorted ). And to compile with older X, 

#ifndef ShapeInput
const int ShapeInput = 2;
#endif

might be helpful.

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak at suse.cz , l.lunak at kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http//www.suse.cz