Review Request 120383: Fix uses of i18n before the main component has been created

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120383/
-----------------------------------------------------------

(Updated Sept. 27, 2014, 10:07 a.m.)


Status
------

This change has been marked as submitted.


Review request for Gardening Team and K3b.


Repository: k3b


Description
-------

It is wrong to do i18n calls before the main component has been created and the domain set. This delays the two cases present in K3b by:
 a) Using KLocalizedString instead i18n so that the real translation is delayed until toString is called
 b) Splitting m_volumeId into m_volumeId and a default value so we don't need to call i18n from the constructor of IsoOptions that is static in a file.


Diffs
-----

  libk3b/projects/datacd/k3bisooptions.h ca8791a 
  libk3b/projects/datacd/k3bisooptions.cpp fe19754 
  src/k3bwritingmodewidget.cpp 6522172 

Diff: https://git.reviewboard.kde.org/r/120383/diff/


Testing
-------

Starts, warning is gone, strings are still there.


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-gardening/attachments/20140927/d66bd487/attachment.html>