Review Request 121278: Make changing the volume on notifications optional and disabled by default

Fri Nov 28 11:04:28 UTC 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121278/
-----------------------------------------------------------

(Updated nov. 28, 2014, 11:04 a.m.)

Review request for Gardening Team, Christoph Feck and Martin Klapetek.

Bugs: 324975
    http://bugs.kde.org/show_bug.cgi?id=324975

Repository: kde-runtime

Description
-------

I don't see why we should change the volume at all, let the user decide their volume, but since we have the feature i didn't want to remove it completely and instead left if disabled by default.

Diffs
-----

  knotify/notifybysound.cpp 0f5cc50 
  kcontrol/knotify/knotify.cpp 0c1b34e 
  kcontrol/knotify/playersettings.ui 54bb627 

Diff: https://git.reviewboard.kde.org/r/121278/diff/

Testing
-------

Tested it, does change and not change the volume according to the setting in system settings.

Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-gardening/attachments/20141128/f765fe56/attachment.html>