Review Request 120796: Don't set the volume if PulseAudio is available

[Albert Astals Cid]

> On Nov. 1, 2014, 12:37 p.m., Albert Astals Cid wrote:
> > I would suggest approaching this from a different perspective.
> > 
> > In the KCM at the moment we have 3 options:
> >  * Use KDE sound system with this volume
> >  * Use an external player
> >  * No audio
> > 
> > Should we split the first one in two
> >  * Use KDE sound system
> >   * [checkbox] Use this volume
> > 
> > And probably even make the second disabled by default?

My take at https://git.reviewboard.kde.org/r/121278


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120796/#review69637
-----------------------------------------------------------


On Oct. 26, 2014, 4:21 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120796/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2014, 4:21 p.m.)
> 
> 
> Review request for Gardening Team and Christoph Feck.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> Simple approach to bug 324975, implementing a suggestion from comment #6. I was however never able to reproduce this locally, so this is "coding blind".
> 
> If this is good-enough, I'll make a similar patch to the kcm to hide the slider in there (which was said in the bug that these should be controllable by the "event sounds" slider).
> 
> (I'm not sure to whom should I assign this so please add people as necessary)
> 
> 
> Diffs
> -----
> 
>   knotify/notifybysound.cpp 0f5cc50 
> 
> Diff: https://git.reviewboard.kde.org/r/120796/diff/
> 
> 
> Testing
> -------
> 
> It builds but I cannot reproduce the problem locally, so cannot really say if it fixes the bug.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-gardening/attachments/20141128/8f73b04c/attachment.html>