Review Request 121278: Make changing the volume on notifications optional and disabled by default

[Harald Sitter]

> On Dec. 3, 2014, 10:07 a.m., Harald Sitter wrote:
> > Quite lovely. I am not sure the label is entirely suitable though.
> 
> Albert Astals Cid wrote:
>     Why is "Force Volume" better than "Change Volume"? Don't both kind of represent the same?

Not sure they do. As I was saying, one also *changes* the volume in kmix. So if the slider was actually changing the event volume then ticking the checkbox would do two things:
a) as I move the slider the event sound slider in kmix would move (or any other pulseaudio mixer for that matter)
b) when I later move the event sound slider in kmix it will actually change the notification volume and thus the slider in the KCM should move.

i.e. IMO calling it 'change' is misleading because the user is not changing the volume, they are forcing the one set in the kcm to override the one in kmix.


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121278/#review71286
-----------------------------------------------------------


On Dec. 2, 2014, 9:15 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121278/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 9:15 p.m.)
> 
> 
> Review request for Gardening Team, Christoph Feck, Martin Klapetek, and Harald Sitter.
> 
> 
> Bugs: 324975
>     http://bugs.kde.org/show_bug.cgi?id=324975
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> I don't see why we should change the volume at all, let the user decide their volume, but since we have the feature i didn't want to remove it completely and instead left if disabled by default.
> 
> 
> Diffs
> -----
> 
>   knotify/notifybysound.cpp 0f5cc50 
>   kcontrol/knotify/knotify.cpp 0c1b34e 
>   kcontrol/knotify/playersettings.ui 54bb627 
> 
> Diff: https://git.reviewboard.kde.org/r/121278/diff/
> 
> 
> Testing
> -------
> 
> Tested it, does change and not change the volume according to the setting in system settings.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-gardening/attachments/20141204/f57a65fc/attachment.html>