Review Request 121278: Make changing the volume on notifications optional and disabled by default

[Harald Sitter]

> On Dec. 3, 2014, 10:07 a.m., Harald Sitter wrote:
> > kcontrol/knotify/playersettings.ui, line 69
> > <https://git.reviewboard.kde.org/r/121278/diff/1/?file=330974#file330974line69>
> >
> >     I think this should be 'Force Volume' or 'Override Volume'.
> >     
> >     At least on Linux from a platform POV setting the volume here will force the volume to override what is set on the notification stream in PulseAudio. 'Change' does not quite reflect that... e.g. one also changes the volume in kmix.
> 
> David Edmundson wrote:
>     do we have a way to change the volume of the notification stream in PA from KDE software?

yes, kmix. http://i.imgur.com/KtDqG3L.png


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121278/#review71286
-----------------------------------------------------------


On Dec. 2, 2014, 9:15 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121278/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 9:15 p.m.)
> 
> 
> Review request for Gardening Team, Christoph Feck, Martin Klapetek, and Harald Sitter.
> 
> 
> Bugs: 324975
>     http://bugs.kde.org/show_bug.cgi?id=324975
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> I don't see why we should change the volume at all, let the user decide their volume, but since we have the feature i didn't want to remove it completely and instead left if disabled by default.
> 
> 
> Diffs
> -----
> 
>   knotify/notifybysound.cpp 0f5cc50 
>   kcontrol/knotify/knotify.cpp 0c1b34e 
>   kcontrol/knotify/playersettings.ui 54bb627 
> 
> Diff: https://git.reviewboard.kde.org/r/121278/diff/
> 
> 
> Testing
> -------
> 
> Tested it, does change and not change the volume according to the setting in system settings.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-gardening/attachments/20141203/37587354/attachment.html>