Review Request 120796: Don't set the volume if PulseAudio is available

Martin Klapetek martin.klapetek at gmail.com
Tue Dec 2 23:04:28 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120796/
-----------------------------------------------------------

(Updated Dec. 3, 2014, 12:04 a.m.)


Status
------

This change has been discarded.


Review request for Gardening Team and Christoph Feck.


Repository: kde-runtime


Description
-------

Simple approach to bug 324975, implementing a suggestion from comment #6. I was however never able to reproduce this locally, so this is "coding blind".

If this is good-enough, I'll make a similar patch to the kcm to hide the slider in there (which was said in the bug that these should be controllable by the "event sounds" slider).

(I'm not sure to whom should I assign this so please add people as necessary)


Diffs
-----

  knotify/notifybysound.cpp 0f5cc50 

Diff: https://git.reviewboard.kde.org/r/120796/diff/


Testing
-------

It builds but I cannot reproduce the problem locally, so cannot really say if it fixes the bug.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-gardening/attachments/20141202/47594faf/attachment.html>


More information about the Kde-gardening mailing list